final round of heavy refactorings (naming some of them, there was more):
a number of renamings, the most important changing the archiveId to archiveLink to remove ambiguity between archive hashe (called archiveID in status-go) and archiveLink (an network identifier for the last archive bundle, e.g. magnet link for BitTorrent and CID for LogosStorage)
introducing NOP pattern in ArchiveManager allowing for:
removing defensive checks like m.torrentConfig != nil && m.torrentConfig.Enabled - this makes code safer and way easier to understand
significantly simplifying life-cycle managent of the new ArchiveManager
improving archive cleanup and thread safety - old torrent implementation was missing out here in a couple of places
porting all the above changes from the branch feat/status-go-codex-integration (status-go/pull/7201) to refactor/extract-archive-service (status-go/pull/7312) - those changes are still not there at the moment of this writing but will be there by Monday 16-FEB. I expect to release the letter PR for review.
next:
For better clarity, below is what still need to happen to close the whole task of integrating LogosStorage with status-go:
fixing tests on status-go/pull/7312 and hopefully getting this PR merged at the beginning of the week
fixing the tests on status-go/pull/7201 - a bit more work as we have here more new LogosStorage tests that need adjustment after heavy refactorings
Contribute to the SDK by providing support for boolean argument logos-cpp-sdk/pull/17 and including the comments from the interface file into the generated header logos-cpp-sdk/pull/16.